Re: [XenPPC] [rfc] [patch] 64-bitize guest handles

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2006-06-28 at 09:15 +0300, Muli Ben-Yehuda wrote:
> On Tue, Jun 27, 2006 at 03:59:00PM -0500, Hollis Blanchard wrote:
> 
> >  #define __DEFINE_XEN_GUEST_HANDLE(name, type) \
> > -    typedef struct { type *p; } __guest_handle_ ## name
> > +    typedef union { unsigned long long l; type *p; }
> >      __guest_handle_ ## name
> 
> Is this bit using unsigned long long ...
> > 
> >  #define DEFINE_XEN_GUEST_HANDLE(name) __DEFINE_XEN_GUEST_HANDLE(name, name)
> >  #define XEN_GUEST_HANDLE(name)        __guest_handle_ ## name
> > -#define set_xen_guest_handle(hnd, val)  do { (hnd).p = val; } while (0)
> > +#define set_xen_guest_handle(hnd, val) \
> > +    do { (hnd).l = (unsigned long)(void *)val; } while (0)
> 
> ... while this one uses unsigned long - on purpose?

Just laziness really; the assignment would work fine. You're right,
though, I should add the extra "long".

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel