WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/

Home

xen-ppc-devel

[Top] [All Lists]

Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32

from [Jimi Xenidis]

[Permanent Link][Original]

To:	Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject:	Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland
From:	Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date:	Mon, 22 May 2006 11:51:25 -0400
Cc:	xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Mon, 22 May 2006 08:51:36 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<1148312329.29273.10.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id:	Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post:	<mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<1148069840.17781.11.camel@xxxxxxxxxxxxxxxxxxxxx> <A9C69114-7F54-4D05-88F3-7435925954B7@xxxxxxxxxxxxxx> <1148312329.29273.10.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx


On May 22, 2006, at 11:38 AM, Hollis Blanchard wrote:

On Fri, 2006-05-19 at 17:28 -0400, Jimi Xenidis wrote:


The next to lines should be guarded by #ifdef CONFIG_XEN

+#include <xen/interface/xen.h>
+#include <xen/public/privcmd.h>


Oh, by the way, the Linux rule is to never ifdef includes, so I won't.

Ok, thanks for pointing this out (tho I think this file violates justabout everything :)).

Anyway.. then the second ifdef:

next line should be guarded by #ifdef IOCTL_PRIVCMD_HYPERCALL

+COMPATIBLE_IOCTL(IOCTL_PRIVCMD_HYPERCALL)


is prolly unnecessary
-JX



_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Hollis Blanchard Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Jimi Xenidis Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Hollis Blanchard Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Hollis Blanchard Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Jimi Xenidis <=

Previous by Date:	Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Hollis Blanchard
Next by Date:	[XenPPC] [PATCH] [rfc] g5 serial discover and driver, Maria Butrico
Previous by Thread:	Re: [XenPPC] [pushed] [ppc] support "version" hcalls, and hcalls from 32-bit userland, Hollis Blanchard
Next by Thread:	[XenPPC] [pushed] [ppc] leave the timebase source as the FW sets it, jimix
Indexes:	[Date] [Thread] [Top] [All Lists]

This site is hosted by Citrix