Re: [Xen-devel] [PATCH 1/2] ioemu: don't use magic number 0xff00000.

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Isaku Yamahata, le Thu 15 Jan 2009 21:22:59 +0900, a écrit :
>     don't use magic number 0xff00000.
>     
> diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
> index d6a9235..f2ec05b 100644
> --- a/hw/cirrus_vga.c
> +++ b/hw/cirrus_vga.c
> @@ -3165,7 +3165,7 @@ static int cirrus_vga_load(QEMUFile *f, void *opaque, 
> int version_id)
>      if (!s->vram_gmfn) {
>          /* Old guest, VRAM is not mapped, we have to restore it
>           * ourselves */
> -        s->vram_gmfn = vga_acc ? s->lfb_addr : 0xff000000;
> +        s->vram_gmfn = vga_acc ? s->lfb_addr : VRAM_RESERVED_ADDRESS;
>          xen_vga_populate_vram(s->vram_gmfn, s->vram_size);
>      }
>      xen_vga_vram_map(s->vram_gmfn, s->vram_size);

Ah, so Stefano's patch actually got applied??  I thought Keir preferred
to stay with allocating video memory from hvmloader.

Note that I do not really care about which way we go, what's important
to keep in mind is that if we revert to qemu populating the video
memory, stubdom-based qemu can _not_ work with the default Xen
parameters, because of memory ballooning.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel