xen-ia64-devel

[Top] [All Lists]

[Xen-ia64-devel] [PATCH] fix compilation error.

from [Isaku Yamahata]

[Permanent Link][Original]

To:	xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-ia64-devel] [PATCH] fix compilation error.
From:	Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date:	Wed, 24 Dec 2008 13:28:49 +0900
Delivery-date:	Tue, 23 Dec 2008 20:28:54 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id:	Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post:	<mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.6i

[IA64]: fix compilation error.

BUILD_BUG_ON() was changed so that now BUILD_BUG_ON() can't be
used with symbol values.
Fortunately dom_fpswa_hypercall_patch() isn't performance critical
so replace BUILD_BUG_ON() with BUG_ON().
Fixed the wrong condition which has off-by-one bug.

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff --git a/xen/arch/ia64/xen/dom_fw_common.c 
b/xen/arch/ia64/xen/dom_fw_common.c
--- a/xen/arch/ia64/xen/dom_fw_common.c
+++ b/xen/arch/ia64/xen/dom_fw_common.c
@@ -275,8 +275,8 @@ dom_fpswa_hypercall_patch(uint64_t brkim
        *entry_imva   = 0;
 
        /* see dom_fw.h */
-       BUILD_BUG_ON((char*)xen_ia64_fpswa_call_stub_end -
-                    (char*)xen_ia64_fpswa_call_stub > 0xff - 16);
+       BUG_ON((char*)xen_ia64_fpswa_call_stub_end -
+              (char*)xen_ia64_fpswa_call_stub > 0xff - 16 + 1);
 
        /* call stub */
        memcpy(patch_imva, xen_ia64_fpswa_call_stub, stub_size);


-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-ia64-devel] [PATCH] fix compilation error., Isaku Yamahata <=

Previous by Date:	[Xen-ia64-devel] [PATCH] Fix some IPF Xen VT-d bugs, Cui, Dexuan
Next by Date:	[Xen-ia64-devel] [PATCH] Fix BUILD_BUG_ON()., Isaku Yamahata
Previous by Thread:	[Xen-ia64-devel] [PATCH] Fix some IPF Xen VT-d bugs, Cui, Dexuan
Next by Thread:	[Xen-ia64-devel] [PATCH] Fix BUILD_BUG_ON()., Isaku Yamahata
Indexes:	[Date] [Thread] [Top] [All Lists]