Re: [Xen-ia64-devel] [Patch][RFC] remove panic_domain in guest_write_eoi() for kexec on HVM

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-10-09 at 23:07 +0900, Akio Takebe wrote:
> Hi,
> 
> I thik the following panic_domain in guest_write_eoi() is not necessary,
> because ia64_eoi() in linux is called without checikng in-service.
> 
>  515 void guest_write_eoi(VCPU *vcpu)
>  516 {
>  517     int vec;
>  518 
>  519     vec = highest_inservice_irq(vcpu);
>  520     if ( vec == NULL_VECTOR ) 
>  521         panic_domain(vcpu_regs(vcpu), "Wrong vector to EOI\n");
>  522     VLSAPIC_INSVC(vcpu,vec>>6) &= ~(1UL <<(vec&63));
>  523     VCPU(vcpu, eoi)=0;    // overwrite the data
>  524     vcpu->arch.irq_new_pending=1;
>  525     wmb();
>  526 }
> 
> What do you think about it?

   The panic does seem a bit much, but shouldn't we return rather than
continue on with a NULL_VECTOR?  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel