Isaku Yamahata write on 2007年2月5日 12:59:
> On Mon, Feb 05, 2007 at 11:47:28AM +0800, Xu, Anthony wrote:
>> Isaku Yamahata write on 2007年2月5日 11:43:
>>> On Mon, Feb 05, 2007 at 11:34:59AM +0800, Xu, Anthony wrote:
>>>> Before calling local_vhpt_flush,
>>>> We need to make sure it is not VTI-domain and it is not per-VCPU
>>>> VHPT,
>>>
>>> local_vhpt_flush() always flushes vhpt associated to pcpu. not vcpu.
>>
>> If HAS_PERVCPU_VHPT(current->domain) is true, or VMX_DOMAIN
>> (current) is true.
>>
>> Vhpt_paddr may be 0,
>> So It erases 64KB memory content that starts from machine address 0.
>
> vhpt_init() initializes vhpt_paddr at xen boot time.
Yes, there is no correctness issue.
But it is a waste of time to call local_vhpt_flsh if it is unnecessary.
And if CONFIG_XEN_IA64_PERVCPU_VHPT is defined,
Vhpt_init should not allocate per-pcpu vhpt, it is a waste of memory.
- Anthony
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|