Re: [Xen-ia64-devel] [PATCH 0/7 TAKE 2] xenoprof for xen/ia64

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Tue, Nov 28, 2006 at 04:17:48PM -0700, Alex Williamson wrote:
>   What do you think about the attached as a further revision of
> 12538_92324e8fcc6e_xenoprof_ia64_xen_side.patch?  I took another 21
> #ifdefs out of it.  It's probably slightly less optimal (extra variables
> mostly), but I think it helps the readability.  Thanks,

Hi Alex.
Looks good and much more readable. Thank you.
I guess that gcc eliminates unused variables because most functions
in perfmon.c have static scope. It wouldn't be so suboptimal. 
I added many #ifdefs brain-deadly at the early stage to get them compiled
into xen somehow. So there might be much room for code clean up.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel