Re: [Xen-ia64-devel] [PATCH] Removed warning messages

[Alex Williamson <alex.williamson@xxxxxx>]

On Sun, 2006-03-19 at 17:32 +0900, Masaki Kanno wrote:
> Hi,
> 
> This patch removed warning messages in vcpu.c, xentime.c and xensetup.c.
> I tested compilation, booting dom0, and creation/destruction domU.

   Applied with the following modification:

@@ -96,8 +98,10 @@ vcpu_set_gr(VCPU *vcpu, unsigned long re
 vcpu_set_gr(VCPU *vcpu, unsigned long reg, UINT64 value, int nat)
 {
        REGS *regs = vcpu_regs(vcpu);
+       long sof;
+
        if (!reg) return IA64_ILLOP_FAULT;
-       long sof = (regs->cr_ifs) & 0x7f;
+       sof = (regs->cr_ifs) & 0x7f;
        if (reg >= sof + 32) return IA64_ILLOP_FAULT;
        setreg(reg,value,nat,regs);     // FIXME: handle NATs later
        return IA64_NO_FAULT;

We can't move the setting of sof before the test for reg being NULL.
Thanks,

        Alex

-- 
Alex Williamson                             HP Linux & Open Source Lab


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel