[Xen-ia64-devel] A potential issue in allocate_rid_range()

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

Hi Dan,

n_rid_blocks should be the number of current domain occupying in
ridblock_owner array.
See below patch.
Because currently ridbits of each domain are 18, this bug isn't exposed,

if ridbits is 19 or bigger, domain can't allocate enough rids.

diff -r 8799d14bef77 xen/arch/ia64/regionreg.c
--- a/xen/arch/ia64/regionreg.c Thu Aug 25 22:53:20 2005
+++ b/xen/arch/ia64/regionreg.c Fri Sep  2 16:24:24 2005
@@ -116,7 +116,7 @@
        ridbits = IA64_MIN_IMPL_RID_BITS;

        // convert to rid_blocks and find one
-       n_rid_blocks = ridbits - IA64_MIN_IMPL_RID_BITS + 1;
+       n_rid_blocks = 1<<(ridbits - IA64_MIN_IMPL_RID_BITS) ;

        // skip over block 0, reserved for "meta-physical mappings (and
Xen)"
        for (i = n_rid_blocks; i < MAX_RID_BLOCKS; i += n_rid_blocks) {

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel