| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 1 of 3 V6] tools/libxc: introduce page_aligned_al
|
To: |
"rshriram@xxxxxxxxx" <rshriram@xxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 1 of 3 V6] tools/libxc: introduce page_aligned_alloc in xc_{minios, linux, solaris, netbsd}.c |
|
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
|
Date: |
Wed, 9 Nov 2011 07:07:16 +0000 |
|
Cc: |
"brendan@xxxxxxxxx" <brendan@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
|
Delivery-date: |
Tue, 08 Nov 2011 23:07:51 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<58a24a7d4b8754069236.1320791986@xxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Citrix Systems, Inc. |
|
References: |
<patchbomb.1320791985@xxxxxxxxxxxxxxxxxxx> <58a24a7d4b8754069236.1320791986@xxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Tue, 2011-11-08 at 22:39 +0000, rshriram@xxxxxxxxx wrote:
> diff -r 54a5e994a241 -r 58a24a7d4b87 tools/libxc/xc_linux_osdep.c
> --- a/tools/libxc/xc_linux_osdep.c Wed Nov 02 17:09:09 2011 +0000
> +++ b/tools/libxc/xc_linux_osdep.c Tue Nov 08 14:26:02 2011 -0800
> @@ -36,9 +36,17 @@
> #include <xen/sys/gntdev.h>
> #include <xen/sys/gntalloc.h>
>
> +#include "xc_private.h"
I'd like to avoid including xc_private from this file. Although it's in
tree it is a plugin and avoiding internal APIs serves to help ensure
that external plugins can actually be written using the public APIs.
I think you can make this function public, as long as you name it
xc_blah.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: |
[Xen-devel] Re: Need help with fixing the Xen waitqueue feature, Olaf Hering |
| Next by Date: |
[Xen-devel] Re: Need help with fixing the Xen waitqueue feature, Olaf Hering |
| Previous by Thread: |
[Xen-devel] [PATCH 1 of 3 V6] tools/libxc: introduce page_aligned_alloc in xc_{minios, linux, solaris, netbsd}.c, rshriram |
| Next by Thread: |
[Xen-devel] Re: [PATCH 1 of 3 V6] tools/libxc: introduce page_aligned_alloc in xc_{minios, linux, solaris, netbsd}.c, Shriram Rajagopalan |
| Indexes: |
[Date]
[Thread]
[Top]
[All Lists] |
|
|
| |
|
Home