WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/6] eliminate cpu_set()

To: "Keir Fraser" <keir@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/6] eliminate cpu_set()
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Mon, 07 Nov 2011 07:39:35 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 07 Nov 2011 06:40:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CADD9C5F.33ACB%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4EB7B997020000780005F4AC@xxxxxxxxxxxxxxxxxxxx> <CADD9C5F.33ACB%keir@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> On 07.11.11 at 15:31, Keir Fraser <keir@xxxxxxx> wrote:
> On 07/11/2011 09:57, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I don't like set_cpu_{present,online} taking a boolean clear/set flag. There
> is no caller that can both set and clear a flag, so it is always hardcoded
> as 0 or 1. And then the reader has to make a (probably not hard) guess what
> that means.
> 
> If you must add an abstraction interface here, better to define four of
> them: {set,clear}_cpu_{present,online}.

Hmm, I don't like this interface design too much either, but again wanted
to follow Linux rather than cooking our own. Do you really want us to
diverge in this respect?

Jan

> Apart from this, all patches are:
> Acked-by: Keir Fraser <keir@xxxxxxx>
> 
>  -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel