WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86/IRQ: fix create_irq() after c/s 24068:692817

To: Jan Beulich <JBeulich@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86/IRQ: fix create_irq() after c/s 24068:6928172f7ded
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Fri, 04 Nov 2011 14:01:44 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 04 Nov 2011 06:07:34 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1320411716; x=1351947716; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=W+Xlrs4pSVp51RO3hF3uNi64LDjYGb29209tbJZwGr4=; b=EGlHBXak9ekwSaFT2u/6YyEXiO6AvB+8FBU/0uoUfHPaaD7qVFQ43MCl gmhZ1JuJd6B1dTqLop3FytrA1ySWOql1Fvu4fNa3N2vnzlkIsHew9NkON sm5+xm9iNBIpRPpEToXQ9CXU+hygDY7PgOKM0adeR4NyMiKe4Bp2zvW1k GrCcfDvXwEmjhsxT1/HTMRYzF9o2E2CkesbXTO2KGnYYqngpmTMgpL9Ty APUhaHqxfPBRER+CQvqRSXUMJVDII;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=kZrJAElWTZ1HpFZCFiCfzRjBuu4JdloUfOQEK+azcLsizFfowaDZ0YR6 qK9Nwjae4S72nSv2rRzCG0HBnZ/CJuK7y0CaSzTcxQPdOUakmMs5Yc3pk o6tMheFbRyUOxS7A32cmVHU7MwOSlhg+P0zGELOImTEdDoKclubieeltf EoxshT8sOIWE8RuSi3ep+5YnXCglXUKwJB4HGLpxKI+AI/NCHLwaoYHQH YS9RgG+mwwb3ZsvIgI0/5jx2UQlIN;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EB3E02B020000780005F027@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <4EB3E02B020000780005F027@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20111010 Iceowl/1.0b2 Icedove/3.1.15
On 11/04/2011 12:52 PM, Jan Beulich wrote:
init_one_irq_desc() must be called with interrupts enabled (as it may
call functions from the xmalloc() group). Rather than mis-using
vector_lock to also protect the finding of an unused IRQ, make this
lockless through using cmpxchg(), and obtain the lock only around the
actual assignment of the vector.

Works for me (machine coming up again).

Juergen

--
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel