Re: [Xen-devel] [PATCH] xenstored: Fix processing of zero-length messages

[Vasiliy Tolstov <v.tolstov@xxxxxxxxx>]

Thanks! Can somebody check ocaml oxenstored for deadlocks when incorrect messages sent to xenstore?

2011/10/31 Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

When a message with zero length is sent to xenstore, the body of the
message was not processed until the socket or ring had more data to
read; this will cause deadlocks if the requestor is waiting on a
response to continue.

Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
---
 tools/xenstore/xenstored_core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 5d308ca..9e6c2c7 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1297,7 +1297,6 @@ static void handle_input(struct connection *conn)
                       goto bad_client;
               in->used = 0;
               in->inhdr = false;
-               return;
       }

       bytes = conn->read(conn, in->buffer + in->used,
--
1.7.6.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

--

Vasiliy Tolstov,

Clodo.ru

e-mail: v.tolstov@xxxxxxxxx

jabber: vase@xxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel