WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the

To: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking
From: Tim Deegan <tim@xxxxxxx>
Date: Thu, 27 Oct 2011 16:02:07 +0100
Cc: andres@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, olaf@xxxxxxxxx, keir.xen@xxxxxxxxx, adin@xxxxxxxxxxxxxx
Delivery-date: Thu, 27 Oct 2011 08:16:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <d13f91c2fe18d58ad27f.1319690034@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1319690025@xxxxxxxxxxxxxxxxxxx> <d13f91c2fe18d58ad27f.1319690034@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
At 00:33 -0400 on 27 Oct (1319675634), Andres Lagar-Cavilla wrote:
>  28 files changed, 519 insertions(+), 101 deletions(-)

And I thought patch 5 was big :)

I'm not going to read the detail of this this time around - I'd like to
only have to review it once. :)  

I wonder whether it would be worth changing the name/signature of the
generic p2m functions in an incompatime way while we're there.  It would
have three advantages:

 - allow the lookup/drop pairs to have nice matching names
 - get rid of the confusingly-named 'gmfn_to_mfn' function 
 - avoid later bugs if patches are forward-ported across this chaneg
   that add p2m lookups (but not corresoponding drops)

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel