WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1 of 6] Move some ats functions into vendor neutr

>>> On 21.10.11 at 15:57, Wei Wang2 <wei.wang2@xxxxxxx> wrote:
> On Friday 21 October 2011 15:08:50 Jan Beulich wrote:
>> >>> On 21.10.11 at 14:55, Wei Wang <wei.wang2@xxxxxxx> wrote:
>> >
>> > # HG changeset patch
>> > # User Wei Wang <wei.wang2@xxxxxxx>
>> > # Date 1319201416 -7200
>> > # Node ID a559e27ffb2c2a3a90dc25f09205b66668dcdbbb
>> > # Parent  121af976b2988de389db139231103ceedd11bb8a
>> > Move some ats functions into vendor neutral directories.
>>
>> You move them from an x86-specific place to common code. I suppose
>> Intel had reasons to expect them to be implemented differently in ia64.
>> Hence they should go into e.g. xen/drivers/passthrough/x86/ instead.
> 
> Well, we don't have that directory yet. Could we change folder structures  
> in 
> passthrough to be architecture first, then vendors, for example:
> passthough/x86/vtd
> passthough/x86/amd                             
> passthough/ia64/vtd

That doesn't make sense - VT-d is for both ia64 and x86. Code that is
common between vendors but architecture specific would reasonably
belong into drivers/passthrough/<arch>/, which is what I
recommended.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel