WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] remove blocked time accounting from xen "clockch

To: Jan Beulich <JBeulich@xxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] remove blocked time accounting from xen "clockchip"
From: Laszlo Ersek <lersek@xxxxxxxxxx>
Date: Thu, 20 Oct 2011 17:02:41 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Joe Jin <joe.jin@xxxxxxxxxx>, Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Thu, 20 Oct 2011 08:05:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EA031B0.2010400@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1318970579-6282-1-git-send-email-lersek@xxxxxxxxxx> <4E9E9D97020000780005C1DE@xxxxxxxxxxxxxxxxxxxx> <4EA031B0.2010400@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110928 Fedora/3.1.15-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.4 Thunderbird/3.1.15
On 10/20/11 16:35, Laszlo Ersek wrote:

I'm convinced the patch is correct, and only the commit message might
need a small fix (mentioning cpu_idle()).

I forgot to say that I also added counters to xen_timer_interrupt(), account_idle_ticks() (called from cpu_idle()), and the idle time branch of account_process_tick(). (The last one is reached from xen_timer_interrupt() via event_handler == &tick_nohz_handler, after highres=off was passed). When the VM was left alone, they were increasing in strict lock-step.

account_idle_time()

  <- account_idle_ticks()
    <- tick_nohz_restart_sched_tick()
      <- cpu_idle()

  <- account_process_tick()
    <- update_process_times()
      <- tick_nohz_handler() [highres=off]
        <- xen_timer_interrupt()

      <- (tick_periodic())
      <- (tick_sched_timer())

The timer interrupt appears to kick cpu_idle(), and the latter accounts for the time spent idly.

Laszlo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel