WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags
From: Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>
Date: Tue, 18 Oct 2011 13:24:52 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Tue, 18 Oct 2011 04:25:37 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=9uCYMza0g5+vWuL9v8loc0kwdrMgufmi5UYK8rIRhrk=; b=TV95mmfhmiEIP3/KJbGtF4//tmisZXUSqPP4VTG+Uj6eq6J3JqVHNlSFECG68yrmLK 9b0dQKZo7tyVYR64zO/H0jS/ekojvD239Tr199V8M9x0pq4N0hXqQNKhVdIG25ilc1TE 3HPyRjDdSG+nfBSoeOV6j8fySdi5gbaschJno=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1318935490.3385.4.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <ae251a2f9490dfa98553.1318594610@loki> <20124.15541.672787.681791@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK7NH6AZ8urX5yAmV3L_zt06NDJa3kgZUgZ8c3hFQG49Pg@xxxxxxxxxxxxxx> <20124.16018.111545.330437@xxxxxxxxxxxxxxxxxxxxxxxx> <CAPLaKK43qoajKpaydqYFP4b0ewXp98txzwH6K9sVeX7pJzAgQg@xxxxxxxxxxxxxx> <CAPLaKK7Ob7qazk=eoTRyEy42R-14Gt_fYv-fBGxvFPM2ksqzFA@xxxxxxxxxxxxxx> <20125.23182.625048.833144@xxxxxxxxxxxxxxxxxxxxxxxx> <1318935490.3385.4.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
2011/10/18 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
>> That would be neater, but I don't think it's helpful to people for us
>> to be renaming our build variables.
>>
>> Anyone who is repackaging Xen (distros, XCP, ...) would prefer the
>> variables to say the same even if the names aren't ideal.
>
> As long as we keep the old names as well is there harm in adding new,
> more descriptive names as well? i.e.
>        $(PREPEND_LIB) $(EXTRA_LIB) ... $(APPEND_LIB)
> ?
>
> or even PREPEND_LIB ?= $(EXTRA_LIB) and "$(PREPEND_LIB) ...
> $(APPEND_LIB)". That way things don't break today and when a packager
> finds they actually need the distinction they can switch.

I've just sent the new patch, it's called

tools/build: create two new variables called APPEND_ and PREPEND_ to
add compile flags at the beginning or at the end of the search path

Please take a look at that one if possible. I've left EXTRA_LIB and
EXTRA_INCLUDES as they where, so the new patch should be harmless for
people still using those, while adding the new PREPEND_ and APPEND_
variables.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel