 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] x86/MSI: drop local cpumask_t variable from msi_
| To: | Jan Beulich <JBeulich@xxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] x86/MSI: drop local cpumask_t variable from msi_compose_msg() |
| From: | Keir Fraser <keir.xen@xxxxxxxxx> |
| Date: | Fri, 14 Oct 2011 15:55:04 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Fri, 14 Oct 2011 07:56:07 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=9BWwt/l95zCcSJRtaxcSsv2V0Kj9bUBHGgAsTV3EqUA=; b=rYu3ECSlcYC1fgglu6qpTFnR3Z11TXbhHf5EP7GrVJe1Smf41vbB+7JusjByJ6iJTw hw3TsejpdQjOy2HvhKr/v712DO4dQ40b8B2Vcz4LxFwQ5uUiQjRjkF6xr31LpQO9RlnU Tt0AiNhjUYwKT8DAJnwRwq8m9u5RMu4uZO/is= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4E984A69020000780005B67D@xxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcyKgUFtpaeCjEX3XkGqfPtWG6G1/A== |
| Thread-topic: | [Xen-devel] [PATCH] x86/MSI: drop local cpumask_t variable from msi_compose_msg() |
| User-agent: | Microsoft-Entourage/12.30.0.110427 |
On 14/10/2011 13:42, "Jan Beulich" <JBeulich@xxxxxxxx> wrote: >> I wonder whether the cpus_empty() check should be a BUG_ON. Or an ASSERT >> pushed into cpu_mask_to_apicid. > > An ASSERT may be reasonable, but simply dropping the check here > may be too - no other code path invoking cpu_mask_to_apicid() has > a similar check. It is certainly not valid to call cpu_mask_to_apicid with an empty mask. Hence an ASSERT would check that precondition, and for all callers. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Para-Virt DomU + HVM DomU with xen 4.1.1 & linux 3.0.6 locks up system, Pasi Kärkkäinen |
|---|---|
| Next by Date: | Re: [Xen-devel] Features and bug fixes for Linux kernel 3.2., Ian Campbell |
| Previous by Thread: | Re: [Xen-devel] [PATCH] x86/MSI: drop local cpumask_t variable from msi_compose_msg(), Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH] tools/build: append user includes and libraries at the end of the compile flags, Roger Pau Monne |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
