WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] libxlu: correctly parse disk "backendtype" field

To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] libxlu: correctly parse disk "backendtype" field
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 7 Oct 2011 22:41:28 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Fri, 07 Oct 2011 14:42:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E8F660C.4010405@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1317313227@xxxxxxxxxxxxxxxxxxxxx> <50cd0fd187b39a263680.1317313232@xxxxxxxxxxxxxxxxxxxxx> <4E8F660C.4010405@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-10-07 at 21:50 +0100, Daniel De Graaf wrote:
> The expression for backendtype was missing a comma.

This appears correct even though things seem to work without, at least:
xl -N block-attach 0 
backendtype=phy,vdev=xvdb,access=w,target=/dev/vg/guest-volume
works as expected. Do you have a test case which fails or did you just
find by code inspection?

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(we need a signed-off-by I suspect)

> 
> --- a/tools/libxl/libxlu_disk_l.l
> +++ b/tools/libxl/libxlu_disk_l.l
> @@ -139,7 +139,7 @@ devtype=disk,?    { DPC->disk->is_cdrom = 0; }
>  devtype=[^,]*,?      { xlu__disk_err(DPC,yytext,"unknown value for type"); }
>  
>  access=[^,]*,?       { STRIP(','); setaccess(DPC, FROMEQUALS); }
> -backendtype=[^,]*? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
> +backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); }
>  
>  vdev=[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); }
>  script=[^,]*,?       { STRIP(','); SAVESTRING("script", script, FROMEQUALS); 
> }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel