 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH/RFC] don't include <xen/sysctl.h> in libxl.h
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH/RFC] don't include <xen/sysctl.h> in libxl.h |
| From: | Guido Günther <agx@xxxxxxxxxxx> |
| Date: | Fri, 7 Oct 2011 19:05:28 +0200 |
| Delivery-date: | Fri, 07 Oct 2011 10:06:57 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20111005181413.GA32317@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20111005181413.GA32317@xxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
Hi,
I'm unsure if libvirt qualifies as "node control tool":
In file included from /tmp/usr/include/libxl.h:137:0,
from libxl/libxl_conf.c:28:
/tmp/usr/include/xen/sysctl.h:31:2: error: #error "sysctl operations are
intended for use by node control tools only"
In file included from /tmp/usr/include/xen/sysctl.h:35:0,
from /tmp/usr/include/libxl.h:137,
from libxl/libxl_conf.c:28:
If not it makes sense to remove the include from libxl.h and include it
in xl_cmdimpl.c directly. This allows libvirt to include libxl.h again
without defining __XEN_TOOLS__.
Does this look correct?
Cheers,
-- Guido
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] ring buffer overflow, Ian Campbell |
|---|---|
| Next by Date: | [Xen-devel] [PATCH][RFC] jump_labels/x86: Use either 5 byte or 2 byte jumps, Steven Rostedt |
| Previous by Thread: | [Xen-devel] [PATCH] libxc: reset ctx->completed on each domain restore, Guido Günther |
| Next by Thread: | Re: [Xen-devel] [PATCH/RFC] don't include <xen/sysctl.h> in libxl.h, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
