Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Fri, 07 Oct 2011 09:55:43 +0200
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 07 Oct 2011 00:56:19 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1317974144; x=1349510144; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=CDD1VhUGd0iAlk5zkK6NPYL8n3qucJJfGYJpSlHnUtw=; b=gJTPV+mcS4wu3QvmgeNKH7i2i7naxwSD/XItm+fSeGOpLNLwyHXGFFve 1c7WQYAFzpVZiQHlg7DgYcwwSGIOoyCy7I6vZeN6bNXinvudDolL7sZh2 fBTWA9SAoRzA6EDfGGjp+8UGdCzM3l9ESbKxXPY2aFpzoBxeOilNUksYg AzanoBp3LrMLnmy7SO1pQvtTqvpis8Vz9r/1PPHUmCBRd0ec+X6QK29o5 qM+snJwDb/0qNHhq5S/4yxwyL41Jw;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=KbTsJ1hoArV9iZyzwaNVUZNLz3rWpb1yNOuOzcZEtUubiFz+AJMGT/mu f4k3yhTG9vSluHPr4mjyd0FHfJ73B2u+rM5HJwfQfVSu+wBmORtZt5FQJ ehLGBZfCitNjs+YJNvZqEpBRX7f2eUJDd0vqYQy3DCWt1DUdSl33/ESEN w3djAdDs4P9KZ1uboXUym+pq00DN8TiYsHO+yBVI8R8cnJEK4QlDz8Glv xRzdEraJKjHTy7R20A3L6nokjXIVo;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1317973890.21903.280.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<67f2c8de11ecb6d05e22.1317962572@nehalem1> <1317973890.21903.280.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Iceowl/1.0b2 Icedove/3.1.13

On 10/07/2011 09:51 AM, Ian Campbell wrote:

On Fri, 2011-10-07 at 05:42 +0100, Juergen Gross wrote:

XEN_ROOT must be set to an absolute path to avoid out of the tree references

How about:

# HG changeset patch
# User Ian Campbell<ian.campbell@xxxxxxxxxx>
# Date 1317973741 -3600
# Node ID d0327c39dff8abdc224e3c19f31e11f0fbeb5c16
# Parent  f17f0df2a2ede01a8c35dc4768a532a4438b1c02
tools: error out on non-absolute $(XEN_ROOT)

Signed-off-by: Ian Campbell<ian.campbell@xxxxxxxxxx>

Acked-by: juergen.gross@xxxxxxxxxxxxxx

diff -r f17f0df2a2ed -r d0327c39dff8 tools/Rules.mk
--- a/tools/Rules.mk    Wed Oct 05 10:43:41 2011 +0100
+++ b/tools/Rules.mk    Fri Oct 07 08:49:01 2011 +0100
@@ -3,6 +3,10 @@
  # `all' is the default target
  all:

+ifeq ($(filter /%,$(XEN_ROOT)),)
+$(error XEN_ROOT must be absolute)
+endif
+
  include $(XEN_ROOT)/Config.mk

  export _INSTALL := $(INSTALL)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



--
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] Avoid relative XEN_ROOT specification