Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config

[Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>]

On 10/06/2011 10:00 AM, Keir Fraser wrote:
> On 06/10/2011 05:40, "Juergen Gross"<juergen.gross@xxxxxxxxxxxxxx>  wrote:
>
> >   Uuh, the same bug was introduced again.
> >   Could you try the following patch:
> Whilst this is definitely a valid fix, Allen's build was crashing out from
> tools/check. This is unlikely to fix it.
His build path suggests he is using xen-4.1-testing. cs23049 was applied 
directly
after branching xen 4.1.
In the current staging tree my patch fixes a similar problem in a different
Makefile.

Allen, which version are you really using?


Juergen

> >   diff -r 0b66e6450ffe tools/libfsimage/xfs/Makefile
> >   --- a/tools/libfsimage/xfs/Makefile     Tue Oct 04 14:18:30 2011 +0200
> >   +++ b/tools/libfsimage/xfs/Makefile     Thu Oct 06 06:32:00 2011 +0200
> >   @@ -1,4 +1,4 @@ XEN_ROOT = ../../..
> >   -XEN_ROOT = ../../..
> >   +XEN_ROOT = $(CURDIR)/../../..
> >
> >    LIB_SRCS-y = fsys_xfs.c
> >
> >
> >   Keir, it is easy to catch this problem: create a .config file in all
> > directories
> >   _above_ $XEN_ROOT containing something like:
> >
> >   $(error usage of relative XEN_ROOT somewhere in $(MAKEFILE_LIST))
> >
> >
> >   Juergen
> >
> >
> > > Allen
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > From: Juergen Gross [mailto:juergen.gross@xxxxxxxxxxxxxx]
> > >   Sent: Tuesday, October 04, 2011 9:45 PM
> > >   To: Kay, Allen M
> > >   Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; keir@xxxxxxx
> > >   Subject: Re: [Xen-devel] build failure caused by $(XEN_ROOT)/.config
> > >
> > >
> > >
> > >
> > >
> > > On 10/04/2011 11:44 PM, Kay, Allen M wrote:
> > >
> > > Hi Keir,
> > >
> > >
> > >
> > > I¹m getting the following build error caused by ³-include
> > > $(XEN_ROOT)/.config² line in Config.mk.  Removing it from Config.mk makes the
> > > error go away.  The OS I¹m using is FC15.  ³$(XEN_ROOT)/.config² does not
> > > exist.
> > >
> > >
> > >
> > > Allen
> > >
> > >
> > >
> > > -------
> > >
> > >
> > >
> > > make[4]: Entering directory `/home/akay/xen-4.1-testing.hg/tools/check'
> > >
> > > make[4]: *** ../../.config: Is a directory.  Stop.
> > >
> > > make[4]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools/check'
> > >
> > > make[3]: *** [subdir-clean-check] Error 2
> > >
> > > make[3]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> > >
> > > make[2]: *** [subdirs-clean] Error 2
> > >
> > > make[2]: Leaving directory `/home/akay/xen-4.1-testing.hg/tools'
> > >
> > > make[1]: *** [clean] Error 2
> > >
> > > make[1]: Leaving directory `/home/akay/xen-4.1-testing.hg'
> > >
> > > make: *** [world] Error 2
> > >
> > >
> > >
> > >
> > >   This is fixed with cs 23049 in xen-unstable:
> > >
> > >   http://lists.xensource.com/archives/html/xen-devel/2011-03/msg01251.html
> > >
> > >
> > >   Juergen
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
--
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel