Re: [Xen-devel] [PATCH] libxl: update nic list API to use common device API style

[Roger Pau Monné <roger.pau@xxxxxxxxxxxxx>]

2011/10/5 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> (I assume everything but the following hunk was a mistake)

I modified your patch and resubmitted it (sorry if that's not ok),
since this is the first place where new functions are added to libxl.

>
>> diff -r 25db0629e338 -r e94763a6bd34 tools/libxl/Makefile
>> --- a/tools/libxl/Makefile      Fri Sep 30 14:27:27 2011 +0100
>> +++ b/tools/libxl/Makefile      Fri Sep 30 14:27:27 2011 +0100
>> @@ -119,7 +119,7 @@ libxlutil.a: $(LIBXLU_OBJS)
>>         $(AR) rcs libxlutil.a $^
>>
>>  xl: $(XL_OBJS) libxlutil.so libxenlight.so
>> -       $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so $(LDLIBS_libxenlight) 
>> $(LDLIBS_libxenctrl)
>> +       $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) libxlutil.so libxenlight.so 
>> $(LDLIBS_libxenlight) $(LDLIBS_libxenctrl)
>>
>>  testidl: testidl.o libxlutil.so libxenlight.so
>>         $(CC) $(LDFLAGS) -o $@ testidl.o libxlutil.so $(LDLIBS_libxenlight) 
>> $(LDLIBS_libxenctrl)
>
> LDLIBS_libxenlight already has -lxenlight in it. I guess this changes
> works around you local addition LDFLAGS=-L/usr/xen42/lib?
>
> I'm not sure what the right answer is here.

Neither do I, I'm not an expert on build processes, but if I need to
append CFLAGS and LDFLAGS to the build process to find my yajl library
libxl should not try to use the libxenligh.so and libxenutil.so from
the CFLAGS/LDFLAGS folder, because they are outdated. If not, the only
option left is to clean my LDFLAGS and CFLAGS folders from previous
Xen versions and compile the new version, but that's risky.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel