WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 2 of 7] tools/check: call all check_* scripts with sh

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 2 of 7] tools/check: call all check_* scripts with shell
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Tue, 04 Oct 2011 16:21:51 +0200
Delivery-date: Tue, 04 Oct 2011 07:24:08 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1317738119; l=2448; s=domk; d=aepfle.de; h=To:From:Date:References:In-Reply-To:Subject: Content-Transfer-Encoding:MIME-Version:Content-Type:X-RZG-CLASS-ID: X-RZG-AUTH; bh=vGj2BWKHBxZzImCvc9YCyVbBh8w=; b=ONbS3adWvuPP4HzaewvrgPu3zXw+637Nnoilvh8fRlEGB+YgYUWzLWUEavgS6p5FjOW 01FQDcnB5bhzM9hhHDnARN+abzxVXP+Ic2yPlE+iUHT/jRKXe8OiH/iSoH7cZbBOIWwEj ZhTfW0Mz/1crWg2g1q9xVjsrDSrcUffl/sE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1317738109@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317738109@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.7.5
# HG changeset patch
# User Olaf Hering <olaf@xxxxxxxxx>
# Date 1317738016 -7200
# Node ID bcd7b8ee7e99dc6348c3132a7248db5829bc53f9
# Parent  c2daf20cf860d942d1105ce2f5fa7e171c536466
tools/check: call all check_* scripts with shell

Adding new check_* scripts via patch should be possible.
Expect that every script is a shell script and call it with sh.
This removes the need for executable permissions of the individual scripts.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r c2daf20cf860 -r bcd7b8ee7e99 install.sh
--- a/install.sh
+++ b/install.sh
@@ -51,7 +51,7 @@ echo "All done."
 
 echo "Checking to see whether prerequisite tools are installed..."
 cd $src/../check
-./chk install
+sh chk install
 echo "All done."
 
 exit 0
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/Makefile
--- a/tools/check/Makefile
+++ b/tools/check/Makefile
@@ -7,13 +7,13 @@ all install: check-build
 # Check this machine is OK for building on.
 .PHONY: check-build
 check-build:
-       PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) ./chk build
+       PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) $(SHELL) chk 
build
 
 # Check this machine is OK for installing on.
 .PHONY: check-install
 check-install:
-       PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) ./chk install
+       PYTHON=$(PYTHON) LIBXENAPI_BINDINGS=$(LIBXENAPI_BINDINGS) $(SHELL) chk 
install
 
 .PHONY: clean
 clean:
-       ./chk clean
+       $(SHELL) chk clean
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/README
--- a/tools/check/README
+++ b/tools/check/README
@@ -1,11 +1,11 @@
 Checks for the suitability of a machine for Xen build or install.
 To check for build suitability use
 
-        ./chk build
+        sh chk build
 
 To check for install suitability use
 
-        ./chk install
+        sh chk install
 
 The chk script will run checks in this directory and print
 the ones that failed. It prints nothing if checks succeed.
@@ -17,4 +17,4 @@ are run for the build check, and files c
 are run for the install check.
 
 Detailed output from the check scripts is in .chkbuild for build
-and .chkinstall for install.
\ No newline at end of file
+and .chkinstall for install.
diff -r c2daf20cf860 -r bcd7b8ee7e99 tools/check/chk
--- a/tools/check/chk
+++ b/tools/check/chk
@@ -53,7 +53,7 @@ for f in check_* ; do
         continue
     fi
     echo -n "Checking $f: "
-    if ./$f 2>&1 ; then
+    if sh $f 2>&1 ; then
         echo OK
     else
         failed=1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel