WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 14 of 24] libxl: add pid path to libxl__spawner_s

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 14 of 24] libxl: add pid path to libxl__spawner_starting
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Tue, 4 Oct 2011 11:09:20 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 04 Oct 2011 02:10:53 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1317719376; l=816; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=hkVYbX1REY0t//MleQcD75Fqe3U=; b=C4t1Ug2O2P98SXKFp26if1j8IxEKBv3jCbQTIqhc0j1rP4BLSMsQA6BR/+j2DoaJWe5 tBHSpk/vMVdWwfy8UwrRQw63LXag7SsWPCzh0PazMJu9DH6bVOqLWzB9Hzjy4xNt/DCF5 0692dF4BrZWPCl1HTgQFS8cnUSoKNEQz1sY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317716599.21903.76.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317657277@xxxxxxxxxxxx> <219ab93f22c049259568.1317657291@xxxxxxxxxxxx> <1317716599.21903.76.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21.rev5535 (2011-07-01)
On Tue, Oct 04, Ian Campbell wrote:

> On Mon, 2011-10-03 at 16:54 +0100, Olaf Hering wrote:

> > +++ b/tools/libxl/libxl_internal.h
> > @@ -250,6 +250,7 @@ typedef struct {
> >  
> >  typedef struct {
> >      char *dom_path; /* from libxl_malloc, only for 
> > libxl_spawner_record_pid */
> > +    char *pid_path; /* from libxl_malloc, only for 
> > libxl_spawner_record_pid */
> 
> Either this new comment is true and you need a strdup() up above where
> you set it and a free() somewhere else (or use libxl__strdup()) or it is
> false and it should be removed and pid_path should be const char *.
> 
> I think the second option is sufficient for the current and new user you
> are about to add?

I duplicated the dom_path line without paying attention to the comment.
A const char *pid_path; is sufficient.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>