| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH RFC 7/8] s390/jump-label: add arch_jump_label_tra
|
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH RFC 7/8] s390/jump-label: add arch_jump_label_transform_early() |
|
From: |
Jan Glauber <jang@xxxxxxxxxxxxxxxxxx> |
|
Date: |
Fri, 30 Sep 2011 16:48:19 +0200 |
|
Cc: |
Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, David Daney <david.daney@xxxxxxxxxx>, Jason Baron <jbaron@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Michael Ellerman <michael@xxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx> |
|
Delivery-date: |
Tue, 04 Oct 2011 01:28:46 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<b1d87557dc3001031ee8d7f69ee97b90cecba6aa.1317338254.git.jeremy.fitzhardinge@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<cover.1317338254.git.jeremy.fitzhardinge@xxxxxxxxxx> <b1d87557dc3001031ee8d7f69ee97b90cecba6aa.1317338254.git.jeremy.fitzhardinge@xxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 2011-09-29 at 16:26 -0700, Jeremy Fitzhardinge wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>
> This allows jump-label entries to be modified early, in a pre-SMP
> environment.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Cc: Jan Glauber <jang@xxxxxxxxxxxxxxxxxx>
Hi Jeremy,
Your patch looks fine, if you can fix the minor compiler warnings
below. Excluding stop_machine() on pre-SMP also looks safer too me.
--Jan
CC arch/s390/kernel/jump_label.o
arch/s390/kernel/jump_label.c: In function ‘__jump_label_transform’:
arch/s390/kernel/jump_label.c:41:2: error: ‘rc’ undeclared (first use in this
function)
arch/s390/kernel/jump_label.c:41:2: note: each undeclared identifier is
reported only once for each function it appears in
arch/s390/kernel/jump_label.c:41:2: warning: passing argument 1 of
‘probe_kernel_write’ makes pointer from integer without a cast [enabled by
default]
include/linux/uaccess.h:108:21: note: expected ‘void *’ but argument is of type
‘jump_label_t’
arch/s390/kernel/jump_label.c:28:19: warning: unused variable ‘args’
[-Wunused-variable]
make[2]: *** [arch/s390/kernel/jump_label.o] Error 1
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] Re: [PATCH RFC 7/8] s390/jump-label: add arch_jump_label_transform_early(),
Jan Glauber <=
|
|
|
| |
|
Home