WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: xen: IPI interrupts not resumed early enough on suspend/

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: [Xen-devel] Re: xen: IPI interrupts not resumed early enough on suspend/resume
From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Mon, 3 Oct 2011 20:42:20 +0200 (CEST)
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Mon, 03 Oct 2011 11:43:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317654626.21903.72.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1317654626.21903.72.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.02 (LFD 1266 2009-07-14)
On Mon, 3 Oct 2011, Ian Campbell wrote:
> I can see a few options for how I might go about solving this in a
> non-hacky way, which approach do you think would be preferable:

The question is whether you need to disable the IPI interrupt at
all. If not, we have a flag for that.
 
>       * Add "IRQF_RESUME_EARLY", driven from syscore_resume, and use it
>         for these interrupts.

That's the preferable solution, as we could use that for PPC as well,
unless we can move stuff around, so we disable stuff later. 

>       * register syscore ops for the Xen event channel subsystem to
>         unmask the IPIs earlier (would probably look a lot like the code
>         removed by 676dc3cf5bc3).

I'd like to avoid that.

>       * add syscore_ops to Xen smp subsystem to unmask the specific IPIs
>         (which it binds at start of day) earlier.
>       * push dpm_(suspend|resume)_noirq down into stop machine region

Where is stomp machine used?

>       * use something other than stop_machine to quiesce system and move
>         to cpu0 for suspend (doesn't seem sensible to reproduce that
>         functionality).

We already shut down the nonboot cpus on suspend. We could do that
_before_ we disable devices and the interrupts.
 
Raphael ?

Thanks,

        tglx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel