WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 7] [OCAML] Remove the uuid library

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 7] [OCAML] Remove the uuid library
From: Jonathan Ludlam <Jonathan.Ludlam@xxxxxxxxxxxxx>
Date: Fri, 30 Sep 2011 13:21:27 +0100
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 30 Sep 2011 05:24:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317368705.26672.206.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1317331042@xxxxxxxxxxxxxxxxxxxxxxxxxx> <42cdb34ec175602fa2d8.1317331044@xxxxxxxxxxxxxxxxxxxxxxxxxx> <1317368705.26672.206.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acx/a3oXpGEGevimR72TNL+ryp0Olw==
Thread-topic: [Xen-devel] [PATCH 2 of 7] [OCAML] Remove the uuid library
On 30 Sep 2011, at 08:45, Ian Campbell wrote:

> On Thu, 2011-09-29 at 22:17 +0100, Jon Ludlam wrote:
>> diff -r c5df5f625ee2 -r 42cdb34ec175 tools/ocaml/libs/xc/META.in
>> --- a/tools/ocaml/libs/xc/META.in
>> +++ b/tools/ocaml/libs/xc/META.in
>> @@ -1,5 +1,5 @@
>> version = "@VERSION@"
>> description = "Xen Control Interface"
>> -requires = "mmap,uuid"
>> +requires = "unix,mmap"
>> archive(byte) = "xc.cma"
>> archive(native) = "xc.cmxa"
> 
> Is the addition of unix here really part of removing uuid? I don't see
> any additional use of unix arising from the change.
> 

No, you're correct - it's a bugfix in the dependencies. I can prepare it as a 
separate patch, if you want?

> xc does seem to use unix already so the change is probably correct, just
> not really part of this change. I'd be happier if it went in separately,
> but:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel