Re: [Xen-devel] [PATCH] tools/check: check for yajl (needed by libxl)

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Fri, 2011-09-30 at 11:35 +0100, Anthony PERARD wrote:
> On Fri, Sep 30, 2011 at 08:36, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > # HG changeset patch
> > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > # Date 1317367995 -3600
> > # Node ID 4b98868690218126b90620d9b43fdd4140145a43
> > # Parent  e50da6b98e3d5933b9c98e8f43096fd3ebbae00d
> > tools/check: check for yajl (needed by libxl)
> >
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> > (note to committer, ensure the new file is executable)
> >
> > diff -r e50da6b98e3d -r 4b9886869021 tools/check/check_yajl_lib
> > --- /dev/null   Thu Jan 01 00:00:00 1970 +0000
> > +++ b/tools/check/check_yajl_lib        Fri Sep 30 08:33:15 2011 +0100
> > @@ -0,0 +1,7 @@
> > +#!/bin/sh
> > +# CHECK-BUILD CHECK-INSTALL
> > +
> > +. ./funcs.sh
> > +
> > +
> > +has_lib libyajl.so || fail "can't find yajl"
> 
> You probably want to check the yajl headers as well, no ?
> #include <yajl/yajl_parse.h>
> #include <yajl/yajl_gen.h>

tools/check seems a bit inconsistent and I'd expect them both to be in
the -dev package but I guess it can't hurt.

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1317379175 -3600
# Node ID de602616358b7def9351850f518e453c68141c4f
# Parent  302b7556edd91a7506f2215bed5302b4b5eaa52a
tools/check: check for yajl (needed by libxl)

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
(note to committer, ensure the new files are executable)

diff -r 302b7556edd9 -r de602616358b tools/check/check_yajl_devel
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tools/check/check_yajl_devel      Fri Sep 30 11:39:35 2011 +0100
@@ -0,0 +1,7 @@
+#!/bin/sh
+# CHECK-BUILD CHECK-INSTALL
+
+. ./funcs.sh
+
+has_header yajl/yajl_parse.h || fail "can't find yajl/yajl_parse.h"
+has_header yajl/yajl_gen.h || fail "can't find yajl/yajl_gen.h"
diff -r 302b7556edd9 -r de602616358b tools/check/check_yajl_lib
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/tools/check/check_yajl_lib        Fri Sep 30 11:39:35 2011 +0100
@@ -0,0 +1,6 @@
+#!/bin/sh
+# CHECK-BUILD CHECK-INSTALL
+
+. ./funcs.sh
+
+has_lib libyajl.so || fail "can't find libyajl.so"



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel