WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH V9 7/7] libxl: Introduce a QMP client

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH V9 7/7] libxl: Introduce a QMP client
From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Date: Thu, 29 Sep 2011 13:43:42 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 29 Sep 2011 05:45:04 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=IQb+HstNXdEvHWIeb8jcpEK9DLUm9n+MO5/xGGaOp98=; b=wEzKNjCenxfEacif6ngzdnXK60hf0jP3z77F1TDfiY/sIpEcC1ZU9gFEI/5XyyUbLm LfYhM/wKK9VCWdzMx83QpNd/XyGEn7+0P1BhjiUSUIDv2/vFEo9tqOyNXDrKHFH/6QE9 4bpHPeC4LvTxFK+rAumW2IPwZ2eAKvjqTxPJY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1317297249.26672.173.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1317296277-2838-1-git-send-email-anthony.perard@xxxxxxxxxx> <1317296277-2838-8-git-send-email-anthony.perard@xxxxxxxxxx> <1317297249.26672.173.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, Sep 29, 2011 at 12:54, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Thu, 2011-09-29 at 12:37 +0100, Anthony PERARD wrote:
>>
>> +    qmp->qmp_fd = socket(AF_UNIX, SOCK_STREAM, 0);
>> +    if (qmp->qmp_fd < 0) {
>> +        return -1;
>> +    }
>
> Is SOCK_CLOEXEC standard enough to use? Probably not.
>
> We should use FD_CLOEXEC though.

Ok, I will send a separate patch for this.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel