Re: [Xen-devel] [PATCH v6 1/5] Introduce git-checkout.sh

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 28 Sep 2011, Ian Jackson wrote:
> stefano.stabellini@xxxxxxxxxxxxx writes ("[Xen-devel] [PATCH v6 1/5] 
> Introduce git-checkout.sh"):
> > Introduce a script to perform git checkout on an external git tree; use
> > git-checkout.sh in ioemu-dir-find.
> ...
> > +#!/bin/sh
> > +
> > +TREE=$1
> > +TAG=$2
> > +DIR=$3
> 
> Missing
>  - set -e
>  - argument count check

Yes, I'll add those.


> > +if test \! -d $DIR-remote; then
> > +   rm -rf $DIR-remote $DIR-remote.tmp;
> 
> Spurious semicolons.

OK.

> >  distclean: subdirs-distclean
> > -   rm -rf ioemu-dir ioemu-remote
> > +   rm -rf ioemu-dir ioemu-dir-remote
> 
> Would it be too much to ask you not to rename this directory ?
 
Honestly I think that keeping the old name is bad: having two qemu trees
cloned by xen-unstable is already confusing enough for both to users and
developers, the very least we can do is naming the two trees meaningfully.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel