xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] xl: fixup "xl save" command line handling

from [Ian Jackson]

[Permanent Link][Original]

To:	Ian Campbell <ian.campbell@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xl: fixup "xl save" command line handling
From:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date:	Tue, 27 Sep 2011 17:32:22 +0100
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 27 Sep 2011 09:32:58 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<311080019e01809614da.1315922810@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups:	chiark.mail.xen.devel
References:	<311080019e01809614da.1315922810@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Ian Campbell writes ("[Xen-devel] [PATCH] xl: fixup "xl save" command line 
handling"):
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1315922772 -3600
> # Node ID 311080019e01809614dac0321b210ef1a9bbcb44
> # Parent  4309ff9535001bdca8db93a439edd86bb4c447cd
> xl: fixup "xl save" command line handling.
> 
> The save file paramter is required so ensure we have enough arguments.

Right.

> The config filename is optional so do not use argv[optind+3], which
> may well happen to be NULL when the paramter is not present but
> relying on that is pretty gross.

It is guaranteed that argv[argc]==NULL but I agree that this part of
the patch is a stylistic improvement.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] xl: fixup "xl save" command line handling, Ian Campbell Re: [Xen-devel] [PATCH] xl: fixup "xl save" command line handling, Ian Jackson <=

Previous by Date:	[Xen-devel] Re: [PATCH] libxl: fix double free at get_all_assigned_devices [and 1 more messages], Ian Jackson
Next by Date:	[Xen-devel] [xen-unstable test] 9097: regressions - trouble: blocked/fail, xen . org
Previous by Thread:	[Xen-devel] [PATCH] xl: fixup "xl save" command line handling, Ian Campbell
Next by Thread:	[Xen-devel] [PATCH] TTM DMA v1.8, Konrad Rzeszutek Wilk
Indexes:	[Date] [Thread] [Top] [All Lists]