WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] xen: change XEN_PLATFORM_PCI to bool default y
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Wed, 21 Sep 2011 15:49:01 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Wed, 21 Sep 2011 15:50:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1316632095.5182.33.camel@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1316608670-23167-1-git-send-email-stefano.stabellini@xxxxxxxxxxxxx> <20110921185102.GJ17357@xxxxxxxxxxxxxxxxx> <1316632095.5182.33.camel@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2
On 09/21/2011 12:08 PM, Ian Campbell wrote:
> On Wed, 2011-09-21 at 19:51 +0100, Konrad Rzeszutek Wilk wrote:
>> On Wed, Sep 21, 2011 at 01:37:50PM +0100, stefano.stabellini@xxxxxxxxxxxxx 
>> wrote:
>>> From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>>>
>>> The xen-platform-pci module is small and for PV on HVM guests is a
>> How small?
> IIRC it is single digit numbers of kb.

lsmod shows it's about 2.5k.

>>  Does it get removed from memory if it never gets loaded?

Nope.

>>> requirement for xenbus.
>> Ok, should it then have a depency on XenBus as well?
> xenbus can't be a module (which is why allowing platform-pci to be is
> causing problems).
>
>> Linus does not like the 'default y' very much. He actually dislikes
>> it quite much as I found when he tore Dan's behind about cleancache.
> In particular case the option is gated on a dependency on another Xen
> option (PVHVM) which doesn't default on. But if you do select PVHVM you
> certainly want this option, so I think that's ok (why else would
> 'default y' even exist?)

It was default 'm' before, so making it 'y' is just the logical mapping
of tristate->bool.

>> .. so I think making it 'default n' is a better option or perhaps
>> making it depend on some other functionality? Or perhaps just remove
>> the tristate/bool altogether so it gets activated if XEN_PVHVM
>> is set?
>>
>> Or remove the XEN_PLATFORM_PCI config option completly and make the
>> config files that build this driver be CONFIG_XENPVHM dependent?
> That would work too. Even better would be to make it an invisible
> Kconfig symbol which PVHVM just selects.

Eh, select is pretty nasty.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel