 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH] libxl: correct allocation size in libxl_list_nics
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH] libxl: correct allocation size in libxl_list_nics |
| From: | Ian Campbell <ian.campbell@xxxxxxxxxx> |
| Date: | Wed, 21 Sep 2011 14:54:44 +0100 |
| Cc: | Ian Campbell <ian.campbell@xxxxxxxxxx> |
| Delivery-date: | Wed, 21 Sep 2011 06:55:53 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mercurial-patchbomb/1.6.4 |
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1316609964 -3600
# Node ID b11af4a5cdc6a94e41a81d456f07b4d70cdb5ffe
# Parent b43fd821d1aebc8671e684bfc285cda7a6002ff1
libxl: correct allocation size in libxl_list_nics
The function returns a list of libxl_nicinfo not libxl_device_nic.
Causes memory corruption on free.
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
diff -r b43fd821d1ae -r b11af4a5cdc6 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Wed Sep 21 13:59:24 2011 +0100
+++ b/tools/libxl/libxl.c Wed Sep 21 13:59:24 2011 +0100
@@ -1296,7 +1296,7 @@ libxl_nicinfo *libxl_list_nics(libxl_ctx
libxl__sprintf(&gc, "%s/device/vif", dompath),
&nb_nics);
if (!l)
goto err;
- nics = res = calloc(nb_nics, sizeof (libxl_device_nic));
+ nics = res = calloc(nb_nics, sizeof (libxl_nicinfo));
if (!res)
goto err;
for (*nb = nb_nics; nb_nics > 0; --nb_nics, ++l, ++nics) {
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] libxl: attempt to cleanup tapdisk processes on disk backend destroy, Ian Campbell |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] libxl: correct allocation size in libxl_list_vm, Ian Campbell |
| Previous by Thread: | [Xen-devel] [PATCH] libxl: attempt to cleanup tapdisk processes on disk backend destroy, Ian Campbell |
| Next by Thread: | Re: [Xen-devel] [PATCH] libxl: correct allocation size in libxl_list_nics, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
