WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] expose shared page count through xenlight

To: Adin Scannell <adin@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] expose shared page count through xenlight
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 21 Sep 2011 10:34:59 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 21 Sep 2011 02:35:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <CAAJKtqpMqpWckNY=a9HrNZY8hT+cmH8odyLM2HKctSMY63=RRA@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <CAAJKtqpMqpWckNY=a9HrNZY8hT+cmH8odyLM2HKctSMY63=RRA@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Adin,

On Thu, 2011-09-15 at 13:17 +0100, Adin Scannell wrote:
> Attached is a simple patch to expose the shared page information
> through libxl and xl.

I think this is generally fine but I'm a bit concerned that the "xl
list" output is now > 80 characters long by default.

Can we only print this info in verbose mode, or only if >=1 domain has
shared pages or something? I don't suppose just printing the total
number of shared pages across the system is as useful as printing the nr
for each domain?

Perhaps we need a get-meminfo type command to get all the various memory
stats for a domain, e.g. sharing, ballooning, paging etc?

Also, was the change from \t to explicit padding in the header
intentional? I agree it's a bit odd to use \t in the header and spaces
in the actual info lines.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel