WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] netback commit history

To: "Ian Campbell" <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] netback commit history
From: "Jan Beulich" <JBeulich@xxxxxxxx>
Date: Tue, 20 Sep 2011 12:04:49 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 20 Sep 2011 04:05:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Ian,

with the upstream netback introduction consisting of a single big commit
I wonder whether you could point me to where the full history of it is.

I'm asking particularly in the context of us being asked to add a safety
check similar to the vif->netbk != NULL one at the beginning of
xenvif_start_xmit() (also in xenvif_interrupt(), but there we have a
similar check in place), which hadn't been in the legacy tree (obviously)
nor in the original multiple-tasklets patch that I retained a copy of. That
is, I'd like to understand the reasons for this check as it seems wrong
to me to have to do it there - I'd rather think that if an interface got
disabled, execution shouldn't even reach that function anymore.

One thing I wonder about in this context is whether the
netif_stop_queue() call from xenvif_close() shouldn't happen before
xenvif_down() (not the least for reasons of symmetry with
xenvif_open()).

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>