|
xen-devel
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while
|
To: |
Andi Kleen <andi@xxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking |
|
From: |
Avi Kivity <avi@xxxxxxxxxx> |
|
Date: |
Wed, 14 Sep 2011 22:56:51 +0300 |
|
Cc: |
Don Zickus <dzickus@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, KVM <kvm@xxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Wed, 14 Sep 2011 13:00:11 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20110914193437.GX7761@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20110907165203.GQ6838@xxxxxxxxxx> <4E67A551.4000502@xxxxxxxxxx> <20110913184044.GN5795@xxxxxxxxxx> <20110913190320.GR7761@xxxxxxxxxxxxxxxxxx> <20110913192152.GO5795@xxxxxxxxxx> <4E7050F7.3000208@xxxxxxxxxx> <20110914144926.GU7761@xxxxxxxxxxxxxxxxxx> <4E70C1BE.7060209@xxxxxxxxxx> <20110914172838.GV7761@xxxxxxxxxxxxxxxxxx> <4E70FFDD.80405@xxxxxxxxxx> <20110914193437.GX7761@xxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/14/2011 10:34 PM, Andi Kleen wrote:
On Wed, Sep 14, 2011 at 10:26:21PM +0300, Avi Kivity wrote:
> On 09/14/2011 08:28 PM, Andi Kleen wrote:
> >> If an NMI hits in an interrupt handler, or in the "after hlt" section
> >> before the write-to-last-nmi-rip, then we'll see that %rip has changed.
> >> If it hits after the write-to-last-nmi-rip instruction (or in the hlt
> >> itself), then we'll also see that %rip has changed, due to the effect of
> >> that instruction.
> >
> >It won't handle multiple NMIs in halt. I assume that's reasonable common.
> >
>
> Why not?
They all have the same original RIPs and there is no way to distingush
them.
That's how we detect multiple NMIs.
1. First NMI is posted
2. NMI handler starts
3. 2nd NMI posted, queued
4. First NMI source handled
5. IRET
6. Queued NMI hits the core
7. back-to-back NMI detected (same rip)
8. Second (and third...) NMI source handled
9. Execution continues.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home