WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 2] mem_event: use different ringbuffers for

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 2] mem_event: use different ringbuffers for share, paging and access
From: Tim Deegan <tim@xxxxxxx>
Date: Wed, 7 Sep 2011 15:55:19 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 07 Sep 2011 07:56:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9b0929f3243ced27c7c3.1315397730@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1315397728@xxxxxxxxxxxx> <9b0929f3243ced27c7c3.1315397730@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Hi, 

At 14:15 +0200 on 07 Sep (1315404930), Olaf Hering wrote:
> mem_event: use different ringbuffers for share, paging and access
> 
> Up to now a single ring buffer was used for mem_share, xenpaging and
> xen-access.  Each helper would have to cooperate and pull only its own
> requests from the ring.  Unfortunately this was not implemented. And
> even if it was, it would make the whole concept fragile because a crash
> or early exit of one helper would stall the others.
> 
> What happend up to now is that active xenpaging + memory_sharing would
> push memsharing requests in the buffer. xenpaging is not prepared for
> such requests.
> 
> This patch creates an independet ring buffer for mem_share, xenpaging
> and xen-access and adds also new functions to enable xenpaging and
> xen-access. The xc_mem_event_enable/xc_mem_event_disable functions will
> be removed. The various XEN_DOMCTL_MEM_EVENT_* macros were cleaned up.
> Due to the removal the API changed, so the SONAME will be changed too.

The Xen-side changes look OK to me.  I'll leave it to the tools
maintainers to comment on changing the libxc interface and version.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel