xen-devel
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
Subject: |
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking |
From: |
Peter Zijlstra <peterz@xxxxxxxxxxxxx> |
Date: |
Fri, 02 Sep 2011 16:47:06 +0200 |
Cc: |
Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, KVM <kvm@xxxxxxxxxxxxxxx>, maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, the |
Delivery-date: |
Fri, 02 Sep 2011 07:49:26 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<38bb37e15f6e5056d5238adac945bc1837a996ec.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<cover.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> <38bb37e15f6e5056d5238adac945bc1837a996ec.1314922370.git.jeremy.fitzhardinge@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 2011-09-01 at 17:55 -0700, Jeremy Fitzhardinge wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>
> We need to make sure interrupts are disabled while we're relying on the
> contents of the per-cpu lock_waiting values, otherwise an interrupt
> handler could come in, try to take some other lock, block, and overwrite
> our values.
Would this make it illegal to take a spinlock from NMI context?
I know that its generally considered bad form, but there's at least one
spinlock that's only taken from NMI context and thus hasn't got any
deadlock potential.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 11/13] x86/ticketlock: only do kick after doing unlock, (continued)
- [Xen-devel] [PATCH 11/13] x86/ticketlock: only do kick after doing unlock, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 12/13] x86/pvticketlock: make sure unlock_kick pvop call is inlined, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 09/13] x86/pvticketlocks: we only need to kick if there's waiters, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 05/13] x86/ticketlocks: when paravirtualizing ticket locks, increment by 2, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 10/13] xen/pvticket: allow interrupts to be enabled while blocking, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking,
Peter Zijlstra <=
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Peter Zijlstra
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Peter Zijlstra
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Andi Kleen
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Stefano Stabellini
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Avi Kivity
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Don Zickus
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking, Don Zickus
|
|
|