WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH v2] xen: x86_32: do not enable iterrupts when ret

To: Igor Mammedov <imammedo@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH v2] xen: x86_32: do not enable iterrupts when returning from exception in interrupt context
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Fri, 02 Sep 2011 11:00:48 +0100
Cc:
Delivery-date: Fri, 02 Sep 2011 03:07:39 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=k3RjyFPgwlxzU4Kt2b4KuC3SR7hraIBnOxqq+vyBQys=; b=f9pkf1EWW7txI1y8zHtP1jQ/0txTLi3Ftt+KGXU1tUuAthNwCxBRZcg0fjmBInIE6S P2rONcsu09hhzfzcvrSCBPAOkIYd4Q7S/hwlJTOqVgE4uxekKl9h33HI1QNe8P29kLbI w9pWKXyOFFWNM78zrYEY/fsMOXUVpTHkQlhJo=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4E609FA1.3010503@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxpVzBI3XgzhCy+0EW9yfvxBvTCqQ==
Thread-topic: [Xen-devel] [PATCH v2] xen: x86_32: do not enable iterrupts when returning from exception in interrupt context
User-agent: Microsoft-Entourage/12.30.0.110427
On 02/09/2011 10:19, "Igor Mammedov" <imammedo@xxxxxxxxxx> wrote:

> BTW, while debugging this issue, I've tried to print saved_upcall_mask
> inside xen when handling page fault from guest. And it value is always
> 0. Looking at asm code for example in xen/arch/x86/x86_32/entry.S:382
> 
>          movzwl TRAPBOUNCE_cs(%edx),%eax 
>                 ^^^^^ upper 16-bit is 0 set in propagate_page_fault
>                       by "tb->cs         = ti->cs;"
> 
>          /* Null selectors (0-3) are not allowed. */
>          testl $~3,%eax
>          jz   domain_crash_synchronous
>          movl %eax,UREGS_cs+4(%esp)
>                    ^^^^^^^^^^^^^^^^ and here is the only place we set
>                    saved_upcall_mask field in current cpu_user_regs
> 
> It looks like "saved_upcall_mask" in cpu_user_regs is not really used
> any more for what it means and it's presence in struct is just confusing
> and misleading.
> 
> So why not delete it and extend _pad1 to 4 bytes?

It's part of the guest ABI.

 -- Keir

> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel