[Xen-devel] Re: [PATCH V4 3/3] xen-blkback: discard requests handling in blkback driver

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Sep 01, 2011 at 06:39:10PM +0800, Li Dongyang wrote:
> Now blkback driver can handle the discard request from guest, we will
> forward the request to phy device if it really has discard support, or we'll
> punch a hole on the image file.

The description should read:

   xen-blkback: Implement discard requests handling
   
    If the backend device (or loopback file) supports discard requests then
    advertise it to the frontend via 'feature-discard'.

    Implementation wise - if the backend is 'phy' - use blkdev_issue_discard,
    while if it is 'file', then punch a hole in the image file.
    
    Signed-off-by: Li Dongyang <lidongyang@xxxxxxxxxx>
.. snip..
> +     if (err == -EOPNOTSUPP) {
> +             pr_debug(DRV_PFX "blkback: discard op failed, "
                          ^^^^^^^ - get rid of that.

The DRV_PFX already provides the 'xen-blkback' string.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel