On Mon, Aug 29, 2011 at 03:47:37PM +0800, Li Dongyang wrote:
> On Sat, Aug 27, 2011 at 1:10 AM, Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx> wrote:
> > On Wed, Aug 24, 2011 at 05:17:54PM +0300, Pasi Kärkkäinen wrote:
> >> On Wed, Aug 24, 2011 at 05:23:42PM +0800, Li Dongyang wrote:
> >> > Dear list,
> >> > this is the V3 of the trim support for xen-blkfront/blkback,
> >>
> >> Isn't the generic name for this functionality "discard" in Linux?
> >
> >>
> >> and "trim" being the ATA specific discard-implementation,
> >> and "scsi unmap" the SAS/SCSI specific discard-implementation?
> >
> > Yeah. I think you are right. The 'feature-discard' sounds much much
> > more generic than the 'trim'. Since we are still implementing this
> > and I think we can take the liberty of making it 'feature-discard'.
> yeah, that's why I use "feature-discard" in the patch at the first time.
> but since the header has already BLKIF_OP_TRIM so I changed that in
> later versions.
> and agree with u feature-discard makes more sense, maybe we also need to
> rename
> BLKIF_OP_TRIM to BLKIF_OP_DISCARD?
Lets get Keir and Ian's input on this.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home