WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyB

To: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyBridge i5-2500 to the vpmu list
From: "Shan, Haitao" <haitao.shan@xxxxxxxxx>
Date: Mon, 29 Aug 2011 21:48:53 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc:
Delivery-date: Mon, 29 Aug 2011 06:49:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201108291439.15910.dietmar.hahn@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201108291439.15910.dietmar.hahn@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcxmSK7HuOehULiLT5GIizW+NHIDDQACReyA
Thread-topic: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyBridge i5-2500 to the vpmu list
Hi,Hahn,

I will have a check tomorrow, though I myself do not own all of the machine now.
As for the quirk, I don't know whether it is needed by later processors. But as 
far as I know, it should not harm profiling tools inside guests.

Shan Haitao

> -----Original Message-----
> From: Dietmar Hahn [mailto:dietmar.hahn@xxxxxxxxxxxxxx]
> Sent: Monday, August 29, 2011 8:39 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: Shan, Haitao
> Subject: [PATCH] vpmu: Add processors Westmere E7-8837 and SandyBridge
> i5-2500 to the vpmu list
> 
> Hi,
> 
> the following patch adds the mentioned processors to the list of vpmu able
> procs.
> Maybe some other processors could get added (i3..., i7...), but I have no
> machines to check this - Haitao?
> I think this patch would be a candidate for backports to 4.0.3 and 4.1.2.
> Should I send a patch too?
> 
> Thanks.
> Dietmar.
> 
> Signed-off-by: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
> 
> Add processors Westmere E7-8837 and SandyBridge i5-2500 to the vpmu list.
> 
> diff -r 227130622561 -r 8ae871cf435a xen/arch/x86/hvm/vmx/vpmu_core2.c
> --- a/xen/arch/x86/hvm/vmx/vpmu_core2.c       Thu Aug 25 12:03:14 2011 +0100
> +++ b/xen/arch/x86/hvm/vmx/vpmu_core2.c       Mon Aug 29 14:13:44 2011
> +0200
> @@ -58,7 +58,8 @@
>      is_pmc_quirk = 0;
>      if ( family == 6 )
>      {
> -        if ( cpu_model == 46 || cpu_model == 26 )
> +        if ( cpu_model == 47 || cpu_model == 46 || cpu_model == 42 ||
> +             cpu_model == 26 )
>              is_pmc_quirk = 1;
>      }
>  }
> diff -r 227130622561 -r 8ae871cf435a xen/arch/x86/hvm/vpmu.c
> --- a/xen/arch/x86/hvm/vpmu.c Thu Aug 25 12:03:14 2011 +0100
> +++ b/xen/arch/x86/hvm/vpmu.c Mon Aug 29 14:13:44 2011 +0200
> @@ -119,7 +119,9 @@
>              case 23:
>              case 26:
>              case 29:
> +            case 42:
>              case 46:
> +            case 47:
>                  vpmu->arch_vpmu_ops = &core2_vpmu_ops;
>                  break;
>              }
> 
> --
> Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>