xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] p2m: use defines for page sizes

from [Tim Deegan]

[Permanent Link][Original]

To:	Christoph Egger <Christoph.Egger@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] p2m: use defines for page sizes
From:	Tim Deegan <tim@xxxxxxx>
Date:	Fri, 26 Aug 2011 13:03:26 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 26 Aug 2011 05:06:16 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4E56439D.9020704@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<4E56439D.9020704@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.4.2.1i

At 14:44 +0200 on 25 Aug (1314283453), Christoph Egger wrote:
> 
> Use defines for page sizes instead of hardcoding the value.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>

Applied, thanks, except for this hunk, where that's not waht 9 means: 

> --- a/xen/arch/x86/mm/p2m-pt.c        Tue Aug 23 14:34:15 2011 +0200
> +++ b/xen/arch/x86/mm/p2m-pt.c        Thu Aug 25 14:29:18 2011 +0200
> @@ -64,7 +64,7 @@ static unsigned long p2m_type_to_flags(p
>       */
>      flags = (unsigned long)(t & 0x7f) << 12;
>  #else
> -    flags = (t & 0x7UL) << 9;
> +    flags = (t & 0x7UL) << PAGE_ORDER_2M;
>  #endif
>  
>  #ifndef __x86_64__

Cheers,

Tim.

-- 
Tim Deegan <tim@xxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] p2m: use defines for page sizes, Christoph Egger Re: [Xen-devel] [PATCH] p2m: use defines for page sizes, Tim Deegan <=

Previous by Date:	RE: [Xen-devel] FW: HXEN on linux, Stefano Stabellini
Next by Date:	Re: [Xen-devel] Kernel bug from 3.0 (was phy disks and vifs timing out in DomU), Stefano Stabellini
Previous by Thread:	[Xen-devel] [PATCH] p2m: use defines for page sizes, Christoph Egger
Next by Thread:	[Xen-devel] [PATCH] linux-2.6.18/ACPI: allow passing down C1 information if no other C-states exist, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]