 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its w
| To: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET |
| From: | Olaf Hering <olaf@xxxxxxxxx> |
| Date: | Thu, 25 Aug 2011 17:19:18 +0200 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 25 Aug 2011 08:22:23 -0700 |
| Dkim-signature: | v=1; a=rsa-sha1; c=relaxed/relaxed; t=1314285612; l=1209; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=MvBxPZRoU5hDSaRD4XqQ9h9jPi4=; b=nMuJDIWn2A9u0C4UtmvQUEZVxo5vem/d6IKpZqQmZWCBon+Sh9sXtimfh92WWKWZmL5 sloVo7yNiW6c+FruAQNaxNyh+lkjCWbwCqSe3SLXmeN9tAAZ3xgZ0NZiLVSgxdWIf9CFJ eMtra/OZN6o6Y3IxGzoIVUe7SHY5UgD0TJ8= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20054.26108.76939.531036@xxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <31687c9a9e3edfae7cf2.1313130830@xxxxxxxxxxxx> <20054.26108.76939.531036@xxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.21.rev5535 (2011-07-01) |
On Thu, Aug 25, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] xenstored: allow guests to shutdown
> all of its watches using XS_RESET"):
> > Add a new XS_RESET command to do the reset on behalf of the guest.
>
> I'm afraid I still think this is wrong.
There is a later patch XS_RESET_WATCHES.
http://lists.xensource.com/archives/html/xen-devel/2011-08/msg00529.html
> * The XS_RESET command as you have it takes too many arguments. It
> should probably not take any arguments at all.
The later patch does not take arguments.
> * You have failed to update the specification document which describes
> the xenstored protocol (in docs/misc/)
The later patch adds the XS_RESET_WATCHES part to the xenstored.txt.
> * Your XS_RESET command doesn't just delete watches and transactions.
> It also:
> - discards outstanding responses to earlier commands
> - discards potential incoming partial commands
> - resets the ring pointers
> I don't think any of these things are necessary. If they are,
> please explain. I think you should have your do_reset simply call
> conn_delete_all_watches and conn_delete_all_transactions.
Thats what the later patch does.
Olaf
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] hotplug: update xencommons script to run only when needed, Ian Jackson |
|---|---|
| Next by Date: | RE: [Xen-devel] [PATCH][VTD] fixing vt-d/ept page table sharing in xen-4.1, Kay, Allen M |
| Previous by Thread: | Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET, Ian Jackson |
| Next by Thread: | Re: [Xen-devel] [PATCH] xenstored: allow guests to shutdown all of its watches using XS_RESET, Ian Jackson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
