[Xen-devel] RE: [PATCH][VTD] fixing vt-d/ept page table sharing in xen-4.1

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

Probably the right thing to do is set this flag in p2m_alloc_table(), after 
calling pagetabel_from_mfn() and before calling iommu_share_p2m_table().   
However, this will require passing the domain pointer to p2m_alloc_table().

What do you think Tim?

Allen

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@xxxxxxxxxx] 
Sent: Monday, August 22, 2011 12:39 AM
To: Kay, Allen M
Cc: Li, Xin; Hao, Xudong; Ren, Yongjie; Xen Devel; keir@xxxxxxx; Tim Deegan
Subject: Re: [PATCH][VTD] fixing vt-d/ept page table sharing in xen-4.1

>>> On 20.08.11 at 03:47, "Kay, Allen M" <allen.m.kay@xxxxxxxxx> wrote:
> Tim/Keir,
> 
> Attached is a patch for fixing VT-d/EPT sharing issue in xen-4.1-testing.  It 
> is base on Tim's patch with the following changes:
> 
> 1) moving "d->arch.paging.mode = mode | PG_HAP_enable" before calling 
> p2m_alloc_table().  Otherwise, the call to iommu_use_hap_pt() in 
> iommu_set_pgd() will not return TRUE.

Wouldn't you need to revert this change in the error paths that sit
between the new and old places of where this happens/happened?

And is it certain that setting this earlier won't confuse other code?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel