WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] clear_IO_APIC() et al

To: <alex.williamson@xxxxxx>,"Keir Fraser" <keir@xxxxxxx>
Subject: [Xen-devel] clear_IO_APIC() et al
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 16 Aug 2011 08:46:20 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 16 Aug 2011 00:46:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
In c/s 20650:b543acc1aaad you made clear_IO_APIC() call both
clear_IO_APIC_pin() and clear_IO_APIC_raw(), and I don't really
follow why the former would be necessary here - the only code
paths we care about are boot and shutdown/crash, and hence
all we want is clearing the actual IO-APIC RTEs (without regard
to interrupt re-mapping).

Furthermore, even clear_IO_APIC_pin() is only called during early
boot, so it would seem to me that we should only need the "raw"
variant.

The context of the question is the need to add some extra code
here to clear the remoteIRR bit if still set (e.g. during a crash), as
that bit remaining set can otherwise lead to later confusion (during
crash handling in the secondary kernel, and when booted through
kexec in Xen itself).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>