WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [SeaBIOS] [PATCH] xen: actually setup hypercalls.

To: Ian Campbell <ijc@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [SeaBIOS] [PATCH] xen: actually setup hypercalls.
From: Kevin O'Connor <kevin@xxxxxxxxxxxx>
Date: Wed, 20 Jul 2011 08:44:31 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, seabios@xxxxxxxxxxx
Delivery-date: Wed, 20 Jul 2011 05:45:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1311154729.20648.178.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1310554267-8881-1-git-send-email-ian.campbell@xxxxxxxxxx> <1311154729.20648.178.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 20, 2011 at 10:38:49AM +0100, Ian Campbell wrote:
> On Wed, 2011-07-13 at 11:51 +0100, Ian Campbell wrote:
> > This was somehow dropped during the iterations of the original Xen patches.
> > It's actually harmless at the moment since there are no users of hypercalls 
> > but
> > patches are being written to support Xen PV block devices which need this.
> > 
> > It's not clear exactly how early this needs to be but I think it needs to 
> > be at
> > least before init_hw() (since that would detect disk devices). I put it 
> > first
> > in maininit() since the only dependency is malloc().
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Ping?

Sorry for the delay.  I'm okay with the patch.  If it doesn't need to
be at the top of maininit though, I'd prefer to move it down a bit.
How about after smm_init?

-Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel