WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] libelf: "required" features should also be reported

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] libelf: "required" features should also be reported as "supported"
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 05 Jul 2011 13:50:03 +0100
Delivery-date: Tue, 05 Jul 2011 05:52:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/xen/common/libelf/libelf-dominfo.c
+++ b/xen/common/libelf/libelf-dominfo.c
@@ -64,13 +64,14 @@ int elf_xen_parse_features(const char *f
         {
             if ( !elf_xen_feature_names[i] )
                 continue;
-            if ( (required != NULL) && (feature[0] == '!') )
+            if ( feature[0] == '!' )
             {
                 /* required */
                 if ( !strcmp(feature + 1, elf_xen_feature_names[i]) )
                 {
                     elf_xen_feature_set(i, supported);
-                    elf_xen_feature_set(i, required);
+                    if ( required )
+                        elf_xen_feature_set(i, required);
                     break;
                 }
             }



Attachment: libelf-required-features-are-supported.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] libelf: "required" features should also be reported as "supported", Jan Beulich <=