xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h

from [Ian Campbell]

[Permanent Link][Original]

To:	Olaf Hering <olaf@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h
From:	Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date:	Mon, 4 Jul 2011 14:27:25 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Mon, 04 Jul 2011 06:28:19 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20110704131823.GA8215@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Citrix Systems, Inc.
References:	<20110704131823.GA8215@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Mon, 2011-07-04 at 14:18 +0100, Olaf Hering wrote:
> testenum.c may fail to compile if libxl.h dependencies are not yet met.

Ah yes, because the automated .*.d dependency tracking hasn't kicked in
on a fresh build yet.

[...]
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> Index: xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> ===================================================================
> --- xen-unstable.hg-4.2.23655.orig/tools/libxl/Makefile
> +++ xen-unstable.hg-4.2.23655/tools/libxl/Makefile
> @@ -52,7 +52,7 @@ $(XL_OBJS): CFLAGS += $(CFLAGS_libxenctr
>  $(XL_OBJS): CFLAGS += $(CFLAGS_libxenlight)
>  
>  testenum.o: CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenlight)
> -testenum.c: libxl.idl gentest.py
> +testenum.c: libxl.idl gentest.py libxl.h
>       $(PYTHON) gentest.py libxl.idl testenum.c.new
>       mv testenum.c.new testenum.c
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Olaf Hering Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Ian Campbell <= Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Ian Jackson

Previous by Date:	[Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Olaf Hering
Next by Date:	[Xen-devel] Re: [PATCH v3] [linux-3.0+ for xen] tmem: self-ballooning and frontswap-selfshrinking, Daniel Kiper
Previous by Thread:	[Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Olaf Hering
Next by Thread:	Re: [Xen-devel] [PATCH] tools/libxl: testenum.c depends on libxl.h, Ian Jackson
Indexes:	[Date] [Thread] [Top] [All Lists]